-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 준비 현황 뷰 구현 #186
[feat] 준비 현황 뷰 구현 #186
Conversation
Conflicts: KkuMulKum.xcodeproj/project.pbxproj
Conflicts: KkuMulKum.xcodeproj/project.pbxproj KkuMulKum/Source/Onboarding/Login/ViewController/LoginViewController.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
짱수고많으셨어요!
} | ||
let participantId, memberId: Int | ||
let name, state: String | ||
let profileImg: String? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
profileImageURL
로 코딩키를 만들어주는 게 다른 모델과도 통일성있을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다 !! 😆
|
||
struct Comer: Codable { | ||
let participantId: Int | ||
let name, profileImg: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분도 마찬가지입니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다 !! 😆
|
||
struct Comer: Codable { | ||
let participantId: Int | ||
let name, profileImg: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅇ ㅕ기두..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇... 이 파일은 삭제되어야 하는데 깜빡했어요 감사합니다 !!
func getMyPromiseStatus(with promiseID: Int) -> MyReadyStatusModel? { | ||
let mockData = MyReadyStatusModel( | ||
preparationTime: 300, | ||
travelTime: 230, | ||
preparationStartAt: "AM 11:00", | ||
departureAt: "PM 1:30", | ||
arrivalAt: "PM 2:00" | ||
) | ||
|
||
return mockData | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
홈화면에 야미하게 가져다 써야지!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~ 👍
저도 모델 수정해야 하는데, 큰일이네요.
let id, dDay: Int | ||
let promiseId, dDay: Int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodingKey를 사용해서 저희 컨벤션에 맞게 promiseID로 수정해도 좋을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다!
🔗 연결된 이슈
📄 작업 내용